[Atlas] Discourse spaces — landscape-scoped discussion forums

Goal

Create landscape-scoped discourse spaces at /landscape/{domain}/discuss (like Reddit subreddits for science domains). Each domain (alzheimers, parkinsons, als, neuroinflammation, lysosomal) gets its own discussion feed showing: new gaps identified, hypotheses posted, reviews submitted, syntheses published, governance decisions proposed. Sub-pages: /gap/{id}/discuss, /hypothesis/{id}/reviews, /mission/{id}/discuss.

Acceptance Criteria

Approach

Step 1: Database Migration

Create a migration to add comment_type TEXT DEFAULT 'discussion' to the comments table.

Step 2: API Changes

Update CommentCreate model to include comment_type: str = 'discussion'

Add comment_type to the INSERT statement in api_create_comment

Create new API endpoint /api/landscape/{domain}/activity that:

- Queries comments filtered by domain (via entity_id joins)
- Supports filtering by comment_type, author_id, date range
- Returns paginated results with infinite scroll cursor

Step 3: HTML Pages

Create the following HTML pages with live search (ajax=1) and infinite scroll:

site/landscape_discuss.html — served at /landscape/{domain}/discuss

Add discuss sub-page content to gap detail page (/gap/{gap_id}/discuss)

Add reviews sub-page content to hypothesis detail page (/hypothesis/{hypothesis_id}/reviews)

Add discuss sub-page content to mission detail page

Comment Types

The following comment types are supported:

• discussion — General discourse (default)
• review — Structured peer review (scores + rationale)
• evidence — Cites a paper/dataset as support or contradiction
• proposal — Proposes a state change (merge, archive, promote)
• synthesis — Aggregated summary of a discussion thread
• fact_check — Community Notes-style verification
• question — Seeking answers

Dependencies

• None (this is a greenfield feature)

Dependents

• Subsequent tasks that add agent subscription/notification to discourse spaces

Work Log

2026-04-13 10:30 PT — Slot minimax:50

• Read AGENTS.md, discussion-discourse-architecture.md, and task description
• Analyzed existing comments table schema and api_get_comments endpoint
• Verified no existing landscape/discuss routes exist
• Started spec file creation

2026-04-13 11:00 PT — Slot minimax:50

• Created migration 092_add_comment_type.py to add comment_type field
• Updated CommentCreate model in api.py (two instances) with comment_type field
• Updated api_create_comment to include comment_type in INSERT and validate it
• Created /api/landscape/{domain}/activity endpoint with filtering support
• Created /landscape/{domain}/discuss HTML page with filters and infinite scroll
• Created /gap/{gap_id}/discuss sub-page with comment threading
• Created /hypothesis/{hypothesis_id}/reviews sub-page with review filtering
• Created /mission/{mission_id}/discuss sub-page with mission-scoped discussion
• Ran migration successfully - comment_type column added
• Verified api.py parses correctly
• Committed changes: [Atlas] Discourse spaces — landscape-scoped discussion forums

2026-04-13 13:00 PT — Slot minimax:50

• Pushed branch but merge gate blocked: commit message didn't mention api.py (critical file)
• Additional issue: branch had deleted 3 unrelated spec files (broken links specs from other tasks)
• Fixed: restored deleted spec files from origin/main, rebased on latest origin/HEAD
• Amended commit message to explicitly mention api.py in all relevant bullet points
• Force pushed corrected commit (b18f540fd) to origin
• Verified: remote branch now shows correct commit with api.py references

2026-04-13 13:15 PT — Slot minimax:50

• Discovered SQL bug in committed api_landscape_activity: WHERE clause used bare column names

(entity_type, entity_id) without table alias c. (aliased from comments table)

• Bug would cause SQL error at runtime when endpoint is called
• Fixed: added c. prefix to all column references in domain_filter template
• Fixed: moved c.is_deleted = 0 into where_clauses list instead of hardcoding in query string
• Fixed: added c. prefix to comment_type, author_id, created_at filter columns
• Committed fix as new commit (0ac6bc7a9) with explicit api.py mention in message
• Pushed successfully

Tasks using this spec (1)

[Atlas] Discourse spaces — landscape-scoped discussion forum

File: fc3fb681_922_spec.md

Modified: 2026-05-01 20:13

Size: 5.0 KB