[Artifacts] Harden demo smoke check coverage for rich artifact routes done

← Artifacts
Extend scripts/demo_smoke_check.py to verify rich artifact and notebook routes used in demo/showcase flows, with explicit pass/fail output and bounded execution. ## REOPENED TASK — CRITICAL CONTEXT This task was previously marked 'done' but the audit could not verify the work actually landed on main. The original work may have been: - Lost to an orphan branch / failed push - Only a spec-file edit (no code changes) - Already addressed by other agents in the meantime - Made obsolete by subsequent work **Before doing anything else:** 1. **Re-evaluate the task in light of CURRENT main state.** Read the spec and the relevant files on origin/main NOW. The original task may have been written against a state of the code that no longer exists. 2. **Verify the task still advances SciDEX's aims.** If the system has evolved past the need for this work (different architecture, different priorities), close the task with reason "obsolete: " instead of doing it. 3. **Check if it's already done.** Run `git log --grep=''` and read the related commits. If real work landed, complete the task with `--no-sha-check --summary 'Already done in '`. 4. **Make sure your changes don't regress recent functionality.** Many agents have been working on this codebase. Before committing, run `git log --since='24 hours ago' -- ` to see what changed in your area, and verify you don't undo any of it. 5. **Stay scoped.** Only do what this specific task asks for. Do not refactor, do not "fix" unrelated issues, do not add features that weren't requested. Scope creep at this point is regression risk. If you cannot do this task safely (because it would regress, conflict with current direction, or the requirements no longer apply), escalate via `orchestra escalate` with a clear explanation instead of committing.

Completion Notes

Auto-completed by supervisor after successful deploy to main

Git Commits (4)

Squash merge: orchestra/task/f16462d7-harden-demo-smoke-check-coverage-for-ric (1 commits)2026-04-16
[Artifacts] Update spec with completed acceptance criteria2026-04-04
[Artifacts] Add /search and /pitch routes to demo smoke check2026-04-04
[Artifacts] Add /search and /pitch routes to demo smoke check2026-04-04
Spec File

Goal

Improve demo reliability by extending the smoke-check script to validate rich artifact routes used in the demo/showcase flow. This ensures notebook and artifact pages remain reachable and that CI reports failures with clear context. The update should stay fast and bounded so it can run in recurring automation safely.

Acceptance Criteria

scripts/demo_smoke_check.py checks additional rich artifact/demo-critical routes.
☑ Smoke-check output clearly reports pass/fail for the new artifact checks.
☑ Verification commands complete successfully and key pages remain healthy.

Approach

  • Review current scripts/demo_smoke_check.py route coverage and identify missing rich artifact surfaces.
  • Add targeted checks for artifact/notebook routes used by demo/showcase pathways with existing timeout controls.
  • Run smoke checks and page/API health verifications; update work log with outcomes.
  • Dependencies

    • None.

    Dependents

    • [Demo] CI: Verify all demo pages load correctly with complete content
    • [Artifacts] CI: Verify notebook coverage and generation completeness

    Work Log

    2026-04-04 10:14 PDT — Slot 5

    • Started task: harden demo smoke checks for rich artifact routes.
    • Retrieved task from Orchestra and confirmed no eligible recurring slot work.
    • Created one-shot task and spec for this increment.
    • Next: review scripts/demo_smoke_check.py and implement route coverage additions.

    2026-04-04 11:15 PDT — Slot 5

    • Reviewed existing build_routes() and identified /search and /pitch as missing demo-critical routes.
    • Added /search (search page, 200 OK) and /pitch (pitch deck page, 200 OK) to build_routes().
    • Smoke check ran clean: 191/191 checks passed.
    • Updated spec work log.
    • Result: Done — added 2 routes to demo smoke check coverage.

    2026-04-16 09:45 UTC — Slot 71 (reopen)

    • Audit found original work was on orphan branch — commits never reached origin/main.
    • Verified /pitch already on origin/main (added by other work), but /search was missing.
    • Added /search, /artifacts, and /compare to DEMO_ROUTES in scripts/smoke_check.py.
    • Ran smoke check: 24/25 passed — /analyses/ returns 307 redirect (pre-existing behavior, not caused by this change).
    • New routes all pass: /search (200), /artifacts (200), /compare (200).

    Payload JSON
    {
      "completion_shas": [
        "79e2c68f70a93339b6a1136c5d4ec07c404817fa",
        "7d4d66ae0caf97f0dd89cecab13704f79bedb38b",
        "9cea61ab59b50a7edd883604ff0f3a31d59a5be8"
      ],
      "completion_shas_checked_at": "2026-04-16T09:47:21.792625+00:00"
    }

    Sibling Tasks in Quest (Artifacts) ↗